Exit event #11
Open
Exit event #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the need you have here and thanks for taking the time to find out what's going on. I agree that it's troublesome to see what went wrong without a hook that provides some information. However, having multiple events that could fire when the library returns control shifts burden to consumers. Rather than adding |
|
An |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
redisis not installed, no event is called (namelyclose). Hence, this PR adds theexitingandexitevents, which pass theexitCodeand allow the developer to identify if there was a problem launchingredis.Also, when calling
closing, pass theresult.errto allow the user code to identify any possible error when parsing the configuration.What do you think?
Thanks